fix: preserve scroll position when returning to library tabs#2576
Closed
stamchry wants to merge 1 commit into
Closed
fix: preserve scroll position when returning to library tabs#2576stamchry wants to merge 1 commit into
stamchry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This fixes an annoying UX issue where navigating away from a library tab (like clicking on an album in the Albums tab) and then pressing back would jump you all the way back to the top of the list.
What changed
I moved the scroll states (
LazyListStateandLazyGridState) out of the individual tabs (Albums, Artists, Songs) and hoisted them up to the parentLibraryScreen.Previously, because the scroll states lived inside the tab composables themselves, they were getting wiped out whenever the Navigation system or the HorizontalPager had to recreate the view upon returning. By holding the states at the
LibraryScreenlevel, the screen's saveable state registry can properly hold onto them while we navigate back and forth.How to test